Skip to content

Conversation

@gitliuyf
Copy link
Contributor

PR Category

Performance Optimization

PR Types

New features

Description

pir conv2d add pass

@paddle-bot
Copy link

paddle-bot bot commented Jun 20, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Jun 20, 2024
@gitliuyf gitliuyf force-pushed the testconv2d branch 4 times, most recently from e48a645 to 0565af9 Compare June 21, 2024 03:05
class Conv2dAddXpuFusePattern : public paddle::drr::DrrPatternBase {
private:
bool enable_int8_;
std::map<std::string, int> quant_post_type_;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
std::map<std::string, int> quant_post_type_;
const std::map<std::string, int>& quant_post_type_;

public:
explicit Conv2dAddXpuFusePattern(
bool enable_int8,
std::map<std::string, int> quant_post_type,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
std::map<std::string, int> quant_post_type,
const std::map<std::string, int>& quant_post_type,

// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
#include "glog/logging.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete

void PassInstrumentor::RunAfterAnalysis(const std::string& name,
TypeId id,
Operation* op) {
VLOG(6) << "kyf -- before check num_regions";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete

Operation* op) {
VLOG(6) << "kyf -- before check num_regions";
if (op->num_regions() == 0) return;
VLOG(6) << "kyf -- after checknum_regions";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete

@gitliuyf gitliuyf force-pushed the testconv2d branch 2 times, most recently from d153682 to bb529b9 Compare June 21, 2024 08:49
@gitliuyf gitliuyf force-pushed the testconv2d branch 3 times, most recently from a4dd00c to 8b5a9a5 Compare June 24, 2024 08:13
Copy link
Contributor

@hong19860320 hong19860320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hong19860320 hong19860320 changed the title [xpu] : pir conv2d add pass; test=develop [xpu] pir conv2d add pass Jun 27, 2024
@hong19860320 hong19860320 merged commit 3bb7c92 into PaddlePaddle:develop Jun 27, 2024
@gitliuyf gitliuyf deleted the testconv2d branch June 27, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants