Skip to content

Conversation

wanghaoshuang
Copy link
Contributor

@wanghaoshuang wanghaoshuang commented Dec 2, 2017

  1. Make ConvTransProjection support for dilation
  2. Fix wrong output size config in Projection.conv unitest while isDeconv=true

fix #6187 #6121

1. Make ConvTransProjection support for dilation
2. Fix err config in Projection.conv unitest while deConv=true
@wanghaoshuang wanghaoshuang changed the title Fix ConvTransProjection bug. Make ConvTransProjection support for dilation Dec 2, 2017
/// test ConvTransProjection
testProjectionConv(1, true);
testProjectionConv(3, true);
// testProjectionConv(3, true);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the current code pass the commented tests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. I forgot to uncomment the tests.
Current code passed the commented tests.

Copy link

@tonyyang-svail tonyyang-svail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. For the record, could you specify your test environment? Since our CI environment will always set dilation to 1.

@wanghaoshuang wanghaoshuang merged commit e09e21b into PaddlePaddle:develop Dec 7, 2017
@wanghaoshuang wanghaoshuang deleted the conv_fix branch December 7, 2017 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make ConvTransProjection support for dilation.

2 participants