[CMake]Optimize the dependency of PIR module and Unittest #60066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
risemeup1
approved these changes
Dec 22, 2023
| set(PYBIND_DEPS ${PYBIND_DEPS} pir) | ||
| endif() | ||
|
|
||
| if(WITH_CUSTOM_DEVICE) |
There was a problem hiding this comment.
windows pir是静态库，有没有统计下，windows，libpaddle.dll增大多少，whl包增大有多少。可能因为whl包体积会影响发版本。最好是把pir打通windows场景下编译动态库方式
There was a problem hiding this comment.
预计会增加20M，最优解法是将pir变成动态库，但当前pir变成动态库难度及遇到的困难都未知，当前windows的cmake治理已经成为项目正常推进中的阻塞点，为了能够尽快推进项目顺利开发，减少开发过程中遇到的windows编译链接问题，这里采用次优解法将pir打入paddle.dll中。后续需要专项解决pir变成动态库的工作
| op_dialect_vjp | ||
| pir | ||
| gtest) | ||
| paddle_test(shape_op_test SRCS shape_op_test.cc DEPS gtest) |
There was a problem hiding this comment.
好的，后续会在这个pr修改：#59790
winter-wang
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Pcard-67164
背景：
cmake代码治理不够彻底，依然存在大量的动静态库混链的问题，在单测模块尤为严重。在这样的条件下，尤其是windows环境下，跨模块使用静态变量的时候存在各种符号链接问题，同时也存在运行时问题。
本PR针对cmake做了一些优化工作：
1，在pir编译静态库的场景下，将符号全部打入paddle.so中，减少动静态库混链产生的全局单例失效问题。
2，优化windows下模块的符号暴露，pir模块内统一规范使用IR_API来暴露，pir模块外统一使用TEST_API来暴露，减少动静态库混链产生的符号未定义以及重定义问题。
3，暴露多处PIR模块隐藏的C++代码语法问题，解决windows下vs系列编译器无法识别 / 处理 PIR模块的一些语言特性及代码写法漏洞
4，phi算子库模块头文件引用优化，解耦Fluid头文件
5，优化单测模块依赖，减少动静态库混链写法