add dot_prod_layer #5724

ranqiu92 · 2017-11-17T06:01:25Z

lcy-seso · 2017-11-17T06:03:37Z

paddle/gserver/tests/test_LayerGrad.cpp

+  config.layerConfig.add_inputs();
+
+  for (auto useGpu : {false, true}) {
+    testLayerGrad(config, "dot_prod", 100, false, useGpu);


这里的batch size 改小一些，不需要用这么大的batch size 跑单测。

lcy-seso · 2017-11-17T06:03:38Z

python/paddle/trainer_config_helpers/layers.py

        size=l.config.size)


+@wrap_name_default()


需要为helper 加单测。

lcy-seso

LGTM.

lcy-seso · 2017-11-17T07:06:17Z

doc/api/v2/config/layer.rst

需要像339行那样的横线。

lcy-seso · 2017-11-17T07:06:40Z

paddle/gserver/layers/DotProdLayer.cpp

句末加上句号吧~

lcy-seso · 2017-11-17T07:08:00Z

paddle/gserver/layers/DotProdLayer.cpp

1UL

The output dimensionality of this layer should be fixed to 1.

lcy-seso · 2017-11-17T07:08:55Z

python/paddle/trainer/config_parser.py

完整的一句话注释之后加上句号吧。

lcy-seso

LGTM.

lcy-seso · 2017-11-17T07:25:14Z

python/paddle/trainer/config_parser.py

这里加一个检测，检查一下两个输入的维度必须相同。

self.get_input_layer(0).size == self.get_input_layer(1).size

lcy-seso · 2017-11-17T07:26:00Z

paddle/gserver/layers/DotProdLayer.cpp

这里检查一下 inv0 和 inv1 的宽度必须相同。

lcy-seso

LGTM

add dot_prod_layer

aa25071

ranqiu92 requested a review from lcy-seso November 17, 2017 06:01

lcy-seso reviewed Nov 17, 2017

View reviewed changes

lcy-seso previously approved these changes Nov 17, 2017

View reviewed changes

lcy-seso reviewed Nov 17, 2017

View reviewed changes

ranqiu92 dismissed lcy-seso’s stale review via bac21d8 November 17, 2017 07:36

Update dot_prod_layer

2e1cd33

lcy-seso approved these changes Nov 17, 2017

View reviewed changes

ranqiu92 merged commit 093c526 into PaddlePaddle:develop Nov 17, 2017

		size=l.config.size)


		@wrap_name_default()

add dot_prod_layer #5724

add dot_prod_layer #5724

Uh oh!

Conversation

ranqiu92 commented Nov 17, 2017 • edited by lcy-seso Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lcy-seso left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lcy-seso left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lcy-seso left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ranqiu92 commented Nov 17, 2017 •

edited by lcy-seso

Loading