Skip to content

[clang-tidy] No. 59,60 bugprone-unused-return-value, bugprone-suspicious-missing-comma #56676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2023
Merged

[clang-tidy] No. 59,60 bugprone-unused-return-value, bugprone-suspicious-missing-comma #56676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .clang-tidy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ bugprone-misplaced-widening-cast,
-bugprone-string-literal-with-embedded-nul,
-bugprone-suspicious-enum-usage,
-bugprone-suspicious-memset-usage,
-bugprone-suspicious-missing-comma,
bugprone-suspicious-missing-comma,
-bugprone-suspicious-semicolon,
-bugprone-suspicious-string-compare,
-bugprone-terminating-continue,
Expand All @@ -42,7 +42,7 @@ bugprone-misplaced-widening-cast,
-bugprone-undelegated-constructor,
bugprone-unhandled-self-assignment,
bugprone-unused-raii,
-bugprone-unused-return-value,
bugprone-unused-return-value,
bugprone-use-after-move,
-bugprone-virtual-near-miss,
-clang-analyzer-apiModeling.StdCLibraryFunctions,
Expand Down
2 changes: 1 addition & 1 deletion paddle/fluid/distributed/fleet_executor/fleet_executor.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ void FleetExecutor::Init(
framework::GetUnusedVars(program_desc.Block(0), ops, {});

for (auto& unique_op : ops) {
unique_op.release();
[[maybe_unused]] auto released_op = unique_op.release();
}

// NOTE: For inference, the vars in inference_root_scope_vars
Expand Down
2 changes: 1 addition & 1 deletion paddle/fluid/framework/ir/mkldnn/compute_propagate_scales_mkldnn_pass.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,7 @@ void ComputePropagateScalesMkldnnPass::ApplyImpl(ir::Graph* graph) const {
FusePassBase::Init(pattern_name, graph);

const std::unordered_set<std::string> scale_immutable_ops = {
"fused_transpose"
"fused_transpose",
"transpose2",
"reshape2",
"pool2d",
Expand Down
2 changes: 1 addition & 1 deletion paddle/fluid/framework/operator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2022,7 +2022,7 @@ void OperatorWithKernel::RunImpl(const Scope& scope,
ExecutionContext(*this, exec_scope, *dev_ctx, *runtime_ctx));
}
if (fallback_to_cpu) {
phi_kernel_.release();
[[maybe_unused]] auto released_kernel = phi_kernel_.release();
}
}

Expand Down
4 changes: 2 additions & 2 deletions paddle/fluid/pybind/eager_legacy_op_function_generator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,11 +488,11 @@ int main(int argc, char* argv[]) { // NOLINT
paddle::operators::RegisterCustomDeviceCommonKernel("fake_device");
#endif

const std::string str = "\"paddle/fluid/eager/api/generated/fluid_generated/";
std::vector<std::string> headers{
"<Python.h>",
"\"paddle/fluid/platform/enforce.h\"",
"\"paddle/fluid/eager/api/generated/fluid_generated/"
"dygraph_forward_api.h\"",
str + "dygraph_forward_api.h\"",
"\"paddle/fluid/pybind/eager_utils.h\"",
"\"paddle/fluid/platform/profiler/event_tracing.h\"",
"\"paddle/fluid/pybind/exception.h\"",
Expand Down