Skip to content

Conversation

@chengduoZH
Copy link
Contributor

@chengduoZH chengduoZH commented Nov 13, 2017

fix #5617

@chengduoZH chengduoZH force-pushed the Add_conv3d_transpose_cudnn_op branch from c2ab087 to ec70f0b Compare November 13, 2017 11:29
@chengduoZH chengduoZH force-pushed the Add_conv3d_transpose_cudnn_op branch from ec70f0b to 6fb4bb8 Compare November 13, 2017 12:25
@chengduoZH chengduoZH force-pushed the Add_conv3d_transpose_cudnn_op branch 6 times, most recently from b19b25e to 6e5a726 Compare November 17, 2017 07:21
@chengduoZH chengduoZH force-pushed the Add_conv3d_transpose_cudnn_op branch from 6e5a726 to 0bc2f41 Compare November 17, 2017 07:23
Copy link
Contributor

@qingqing01 qingqing01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

ops::GemmConvTransposeKernel<paddle::platform::CPUPlace, float>);
REGISTER_OP_CPU_KERNEL(
conv3d_transpose_cudnn_grad,
ops::GemmConvTransposeGradKernel<paddle::platform::CPUPlace, float>);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REGISTER double for these ops.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@qingqing01 qingqing01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

REGISTER_OP_GPU_KERNEL(conv3d_transpose_cudnn,
ops::CudnnConvTransposeOpKernel<float>);
REGISTER_OP_GPU_KERNEL(conv3d_transpose_cudnn_grad,
ops::CudnnConvTransposeGradOpKernel<float>);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no double for these ops. Please add in next PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

@chengduoZH chengduoZH merged commit 0f83674 into PaddlePaddle:develop Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add conv3d_trans_cudnn_op

2 participants