Skip to content

Conversation

@zzk0
Copy link
Contributor

@zzk0 zzk0 commented Jun 1, 2023

PR types

Others

PR changes

Others

Description

为以下算子的单测开启With CINN测试:

算子名 备注
arg_max/arg_min -
reverse -
flip -
triangular_solve -
scatter_nd -
strided_slice -

上述算子存在的问题已经在 PaddlePaddle/CINN#1485 中修复。

@paddle-bot
Copy link

paddle-bot bot commented Jun 1, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jun 1, 2023
Copy link
Contributor

@thisjiang thisjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这些单测都要加到https://github.com/PaddlePaddle/Paddle/blob/develop/test/legacy_test/CMakeLists.txt#L1156 TEST_CINN_OPS列表里,不然CI不会跑到

Copy link
Contributor

@thisjiang thisjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thisjiang thisjiang merged commit b835261 into PaddlePaddle:develop Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants