Skip to content

Conversation

@liuzhenhai93
Copy link
Contributor

@liuzhenhai93 liuzhenhai93 commented May 20, 2023

PR types

Others

PR changes

Others

Description

  • 精简 virtual pipeline 调度逻辑,剔除了一些不必要的 对 corner case 的处理
  • card-71221

@paddle-bot
Copy link

paddle-bot bot commented May 20, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot
Copy link

paddle-bot bot commented May 20, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

@liuzhenhai93 liuzhenhai93 changed the title Unify vpp code 精简 virtual pipeline 调度逻辑 May 22, 2023
@liuzhenhai93 liuzhenhai93 requested a review from sneaxiy May 22, 2023 01:45
@sneaxiy sneaxiy requested a review from FeixLiu May 22, 2023 06:52
@FeixLiu
Copy link
Contributor

FeixLiu commented May 22, 2023

在commit信息中加入 test=allcases 关键字触发所有单测,否则pp的单测可能会被跳过

Copy link
Contributor

@FeixLiu FeixLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,改一下commit messsage,让单测跑一下 test_parallel_dygraph_pipeline_parallel_with_virtual_stage 这个单测

@sneaxiy sneaxiy merged commit 6fde205 into PaddlePaddle:develop May 22, 2023
@liuzhenhai93 liuzhenhai93 deleted the unify_vpp_code branch May 24, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants