Skip to content

Conversation

@FeixLiu
Copy link
Contributor

@FeixLiu FeixLiu commented May 6, 2023

PR types

Others

PR changes

Others

Description

no value clip for parallel cross entropy

@paddle-bot
Copy link

paddle-bot bot commented May 6, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@gongweibao gongweibao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

单测不需要修改吗?

@FeixLiu FeixLiu force-pushed the parallel_cross_entropy_no_value_clip branch from a88091f to b7e4da2 Compare May 10, 2023 06:19
@FeixLiu FeixLiu requested a review from gongweibao May 10, 2023 08:11
Copy link
Contributor

@gongweibao gongweibao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FeixLiu FeixLiu merged commit 65a3a58 into PaddlePaddle:develop May 10, 2023
@FeixLiu FeixLiu deleted the parallel_cross_entropy_no_value_clip branch May 10, 2023 11:18
FeixLiu added a commit to FeixLiu/Paddle that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants