Skip to content

Conversation

@co63oc
Copy link
Contributor

@co63oc co63oc commented Apr 6, 2023

PR types

Others

PR changes

Others

Describe

index_add算子增加 BF16 支持,FP16/BF16单测
index_sample算子已有FP16/BF16,FP16单测,增加BF16 单测
put_along_axis算子增加 BF16 支持,FP16/BF16单测
take_along_axis算子增加 BF16 支持,FP16/BF16单测

@paddle-bot
Copy link

paddle-bot bot commented Apr 6, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@co63oc
Copy link
Contributor Author

co63oc commented Apr 11, 2023

@luotao1 @ZzSean CI已完成,麻烦review下

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

尝试使用默认值,若不通过再调整

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改继承 TestIndexAddOp

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这部分是不是可以直接继承TestIndexAddOp,减少重复代码

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

默认值为1e-2,可以不用设置

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

@co63oc
Copy link
Contributor Author

co63oc commented Apr 15, 2023

@luotao1 @ZzSean CI已完成

Copy link
Contributor

@ZzSean ZzSean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants