[AMP OP&Test] pad3d add unittests of fp16 and bf16 #51015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Vvsmile
reviewed
Mar 3, 2023
| self.python_api = paddle.nn.functional.pad | ||
| self.inputs = {'X': np.random.random(self.shape).astype("float64")} | ||
| self.inputs = { | ||
| 'X': np.random.random(self.shape).astype("float32") |
There was a problem hiding this comment.
出于单测后续一致性的考虑，请使用uniform替换random，调用原语请参考https://numpy.org/doc/stable/reference/random/generated/numpy.random.rand.html 和 https://numpy.org/doc/stable/reference/random/generated/numpy.random.uniform.html
Vvsmile
reviewed
Mar 3, 2023
| self.check_output(check_eager=True, atol=1e-3) | ||
|
|
||
| def test_check_grad(self): | ||
| self.check_grad(['X'], 'Out', max_relative_error=0.3) |
There was a problem hiding this comment.
0.3这个值和规范所给阈值不同，这个值是本地测试出来的么？
ZzSean
changed the title
|
LGTM |
luotao1
approved these changes
Mar 29, 2023
ZzSean
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe