Enable matmul + bias fusion in fused_gat_attention. #50755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xreki
force-pushed
the
op/fused_gate_attention_opt
branch
from
4ba359b to
0ae9d63
Compare
Xreki
force-pushed
the
op/fused_gate_attention_opt
branch
from
0ae9d63 to
44761b4
Compare
Xreki
force-pushed
the
op/fused_gate_attention_opt
branch
from
7565381 to
37451fd
Compare
Xreki
force-pushed
the
op/fused_gate_attention_opt
branch
from
37451fd to
f51c61b
Compare
sneaxiy
reviewed
Feb 26, 2023
| } else if (std::is_same<T, phi::dtype::bfloat16>::value) { | ||
| return CUDA_R_16BF; | ||
| #endif | ||
| } |
There was a problem hiding this comment.
How about throw error here?
sneaxiy
approved these changes
Feb 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Performance optimization
PR changes
OPs
Describe
重组fused_gemm_epilogue算子的实现，提取出函数
ComputeFusedGemmEpilogueForward、ComputeFusedGemmEpilogueBackward，并应用于fused_gated_attention算子中，进一步将Gate Linear和Output Linear中的matmul+bias计算进行融合。