Skip to content

Conversation

@cyber-pioneer
Copy link
Contributor

@cyber-pioneer cyber-pioneer commented Feb 15, 2023

PR types

Others

PR changes

Others

Describe

Remove restriction of prim forward in windows and mac

@paddle-bot
Copy link

paddle-bot bot commented Feb 15, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@cyber-pioneer cyber-pioneer force-pushed the dev_win branch 2 times, most recently from 599e793 to d4d3c65 Compare February 19, 2023 12:51
@cyber-pioneer cyber-pioneer changed the title check prim forward in windows and mac [Prim]check prim forward in windows and mac Feb 20, 2023
Copy link
Contributor

@JiabinYang JiabinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JiabinYang JiabinYang merged commit 7fc9f43 into PaddlePaddle:develop Feb 20, 2023
Copy link
Contributor

@JiabinYang JiabinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix problem in softmax in next pr

if not x.shape:
# do not return 1, to ensure gradients
res = divide(x + 1e-5, x + 1e-5)
res = exp(x - x)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants