Skip to content

Conversation

RedContritio
Copy link
Contributor

PR types

Bug fixes

PR changes

OPs

Describe

Solution

  • 限制 stride != 0

@paddle-bot
Copy link

paddle-bot bot commented Jan 22, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot-old paddle-bot-old bot added the contributor External developers label Jan 22, 2023
@Ligoml Ligoml mentioned this pull request Jan 23, 2023
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为这个case加个单测吧

@RedContritio
Copy link
Contributor Author

为这个case加个单测吧

已添加

Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@weisy11 weisy11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 3ab6faa into PaddlePaddle:develop Feb 1, 2023
pangengzheng pushed a commit to pangengzheng/Paddle that referenced this pull request Feb 2, 2023
…/max_pool3d (PaddlePaddle#50010)

* add stride check for MaxPool

* add unittests
@RedContritio RedContritio deleted the maxpool_stride branch February 13, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants