Fix 空指针 (Null pointer) of case15: paddle.broadcast_tensors #49980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+36
to
+41
| output_shape = [1 for i in range(output_rank)] | ||
| for i in range(output_rank): | ||
| for x in input_list: | ||
| shape = list(reversed(x.shape)) | ||
| size = 1 | ||
| if i < len(shape): | ||
| size = shape[i] | ||
| output_shape[i] = max(output_shape[i], size) | ||
| if i < len(shape) and shape[i] != 1: | ||
| output_shape[i] = shape[i] |
There was a problem hiding this comment.
如果不修改的话，默认的方法不支持含有 dim = 0 的数组。
因为原有 max 取 dim 和 size = 1 时，会忽略 dim == 0 的维度。
pangengzheng
pushed a commit
to pangengzheng/Paddle
that referenced
this pull request
Feb 2, 2023
…dle#49980) * fix incorrect output shape of broadcast * add unittest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
OPs
Describe
Solution
修改了错误的
output.shape更新逻辑，使其支持长度为 0 的输入维度。