[Zero-Dim] Fix 0-dim tensor for arg_min_max op. #49570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhwesky2010
reviewed
Jan 6, 2023
paddle/phi/infermeta/unary.cc
Outdated
| if (dtype == phi::TransToProtoVarType(DataType::INT32)) { | ||
| int64_t all_element_num = 0; | ||
| if (flatten) { | ||
| if (x_rank == 0) { |
There was a problem hiding this comment.
这个也不用写分支，因为phi::product(x_dims); 里面已经支持了0D的product计算结果是1
There was a problem hiding this comment.
额，这里有个flatten的配置，怕这个 为 false的话，后面可能有问题。
There was a problem hiding this comment.
0D的时候axis只能为None，就是flatten的情况
zhwesky2010
reviewed
Jan 13, 2023
| // TODO(ZHUI): fix dtype of out | ||
| dev_ctx.template Alloc<int64_t>(out); | ||
| if (x.dims().size() == 0) { | ||
| phi::funcs::set_constant(dev_ctx, out, 0); |
There was a problem hiding this comment.
XPU的设置为常数：
xpu::constant<T>(
dev_ctx.x_context(), dx_data, x->numel(), static_cast<T>(1.0));
zhwesky2010
reviewed
Feb 1, 2023
zhwesky2010
approved these changes
Feb 1, 2023
pangengzheng
pushed a commit
to pangengzheng/Paddle
that referenced
this pull request
Feb 2, 2023
* fix 0-d tensor for arg_min_max op. * fix xpu. * fix zero dims * fix * Update arg_min_max_kernel.cc * Update arg_min_max_kernel.cc * Update arg_min_max_kernel.cc * Update test_zero_dim_tensor.py * Update test_zero_dim_tensor_xpu.py * Update test_zero_dim_tensor.py * Update arg_min_max_kernel.cc * Update arg_min_max_kernel.cc * Update arg_min_max_kernel.cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
Fix 0-dim tensor for arg_min_max op.