[PHI decoupling] move "gpu_primitives.h" to phi #48015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
YuanRisheng
approved these changes
Nov 16, 2022
| @@ -0,0 +1,610 @@ | |||
| /* Copyright (c) 2016 PaddlePaddle Authors. All Rights Reserved. | |||
| See the License for the specific language governing permissions and | ||
| limitations under the License. */ | ||
|
|
||
| #pragma once |
There was a problem hiding this comment.
把Fluid下的gpu_primitives里重复的代码删了吧，避免维护俩份代码，如果这个PR感觉改的太多的话，可以下个PR再弄
There was a problem hiding this comment.
把Fluid下的gpu_primitives里重复的代码删了吧，避免维护俩份代码，如果这个PR感觉改的太多的话，可以下个PR再弄
嗯嗯，打算下一个PR再弄。
This was referenced Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
move
"paddle/fluid/platform/device/gpu/gpu_primitives.h"to phi