Skip to content

Conversation

@jakpiase
Copy link
Contributor

@jakpiase jakpiase commented Nov 9, 2022

PR types

Function optimization

PR changes

OPs

Describe

Added optimization pass for oneDNN layernorm kernel. Now ScaleShift memory can be created from ScaleShift tensor instead of having to copy Scale and Bias at every iteration

@paddle-bot
Copy link

paddle-bot bot commented Nov 9, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Nov 9, 2022
@paddle-bot
Copy link

paddle-bot bot commented Nov 9, 2022

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@onecatcn onecatcn requested a review from yeliang2258 November 9, 2022 08:50
@yeliang2258
Copy link
Contributor

@jakpiase Please update the code and pass CI first, thanks.

@jczaja jczaja requested review from Silv3S and jczaja November 15, 2022 08:30
Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Silv3S Silv3S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jczaja jczaja merged commit 519e742 into PaddlePaddle:develop Nov 15, 2022
@paddle-bot
Copy link

paddle-bot bot commented Nov 15, 2022

你的PR已合入Paddle库,请关注后续测试结果。
Your PR has been merged into the repository. An official integration test will be conducted later. Stay tuned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers Intel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants