fix bug that no thread is waked up when adding task to threadpool #41567
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Describe
fix bug that no thread is waked up when adding task to threadpool
For better performance, when
AddTaskis called, if there are still active thread (blocked_ != num_threads) in threadpool,notifyis not called.In very rare cases, the last active thread of a threadpool is running in
WaitForWork, and in that case, the thread that callingAddTaskmay read theblocked_before itsblocked_++, thusblocked_ != num_threadsand do not callnotify. While, the last active thread is going towaitstate, which result in the added task is not executed. And the whole program hangs.For example, in the following figure, the task added to pool 0 (host pool) is not executed, and the program hangs because the deps of op 5 can not be reduced to 1.