Skip to content

Move gather_nd/scatter/scatter_nd_add op to the phi library #40090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 4, 2022
Merged

Move gather_nd/scatter/scatter_nd_add op to the phi library #40090

merged 6 commits into from
Mar 4, 2022

Conversation

@sneaxiy
Copy link
Collaborator

@sneaxiy sneaxiy commented Mar 2, 2022

PR types

Others

PR changes

OPs

Describe

Move gather_nd/scatter/scatter_nd_add op to the phi library.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Mar 2, 2022

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@sneaxiy sneaxiy requested a review from chenwhql March 2, 2022 13:59
@sneaxiy sneaxiy requested a review from XiaoguangHu01 March 3, 2022 02:32
chenwhql
chenwhql reviewed Mar 3, 2022
View reviewed changes
chenwhql
chenwhql approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XiaoguangHu01
XiaoguangHu01 approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sneaxiy sneaxiy merged commit 1ca379b into PaddlePaddle:develop Mar 4, 2022
@sneaxiy sneaxiy deleted the phi_movement_op branch March 4, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenwhql chenwhql chenwhql approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sneaxiy @chenwhql @XiaoguangHu01