Skip to content

Conversation

@jakpiase
Copy link
Contributor

PR types

Bug fixes

PR changes

OPs

Describe

Fix for conv2D training error on LeNet model. The issue was associated with wrong weights datatype(in inference they are in FP32 datatype, but in training they are in BF16). Also fixed error with no re-creating backward weights primitive descriptor in isCached method

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jczaja jczaja requested review from arlesniak and wozna January 13, 2022 16:36
@jczaja
Copy link
Contributor

jczaja commented Jan 13, 2022

@tsocha , @pawelpiotrowicz Please review

Copy link
Contributor

@arlesniak arlesniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakpiase
Copy link
Contributor Author

Hi @Aganlengzi, could you please review and merge this PR?

Copy link
Contributor

@Aganlengzi Aganlengzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aganlengzi Aganlengzi merged commit 944ea43 into PaddlePaddle:develop Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants