-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Handled Dispensable Inputs/Outputs in Eager AutoCodeGen #37959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handled Dispensable Inputs/Outputs in Eager AutoCodeGen #37959
Conversation
… eager_dygraph_codegen_debug
… eager_dygraph_codegen_debug
… eager_dygraph_codegen_debug
… eager_dygraph_codegen_output_as_arg
|
Thanks for your contribution! |
… eager_dygraph_codegen_dispensable
… eager_dygraph_codegen_dispensable
… eager_dygraph_codegen_dispensable
… eager_dygraph_codegen_dispensable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| FWD_INS_CONTENT_TEMPLATE, input_name, input_name, input_name); | ||
| } else { | ||
| const char* FWD_INS_CONTENT_TEMPLATE = | ||
| " if(%s.initialized()) " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check Variable's initialization status in later PR
| for (const proto::OpProto::Var& input : in_vars) { | ||
| const std::string& input_name = input.name(); | ||
| size_t input_position = fwd_inputs_name_pos_map.at(input_name); | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this blank line in next PR
PR types
New features
PR changes
Others
Describe
Handled Dispensable Inputs/Outputs in Eager AutoCodeGen.