Put_along_axis #37921
Closed
Put_along_axis #37921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zhhsplendid
reviewed
Dec 22, 2021
iclementine
reviewed
Dec 24, 2021
iclementine
reviewed
Dec 24, 2021
iclementine
reviewed
Dec 24, 2021
| ops::TakeAlongAxisOpKernel<double>, | ||
| ops::TakeAlongAxisOpKernel<int>, | ||
| ops::TakeAlongAxisOpKernel<uint8_t>, | ||
| ops::TakeAlongAxisOpKernel<int64_t>); |
There was a problem hiding this comment.
Is it possible to register for complex64 and complex128?
There was a problem hiding this comment.
I don't think so, since the python API level won't support complex type.
There was a problem hiding this comment.
Is complex type not supported in python?
There are some python APIs with complex dtype support.
iclementine
reviewed
Dec 24, 2021
iclementine
reviewed
Dec 24, 2021
iclementine
reviewed
Dec 24, 2021
iclementine
reviewed
Dec 24, 2021
iclementine
reviewed
Dec 24, 2021
There was a problem hiding this comment.
- There are some suggesting on code style and sementic issues;
- implementation of the gradient of put along aixs seems errorous(both the gradient of input & value should be computed, correctly). I think this is also the reason why it cannot pass grad check.
- add docstring for APIs.
iclementine
reviewed
Dec 24, 2021
huangxu96
force-pushed
the
gather
branch
3 times, most recently
from
e03d420 to
31715a0
Compare
huangxu96
force-pushed
the
gather
branch
2 times, most recently
from
fc1e7e8 to
ee0c213
Compare
iclementine
reviewed
Dec 29, 2021
zhhsplendid
reviewed
Dec 29, 2021
| VLOG(3) << "<<<< Done gpu_scatter_mul_kernel <<<<<"; | ||
| } | ||
|
|
||
| namespace plat = paddle::platform; |
There was a problem hiding this comment.
It seems you didn't change what I said...
|
iclementine
reviewed
Dec 30, 2021
chenwhql
reviewed
Dec 30, 2021
| using framework::OperatorWithKernel::OperatorWithKernel; | ||
|
|
||
| void InferShape(framework::InferShapeContext* ctx) const override { | ||
| PADDLE_ENFORCE_EQ( |
zhhsplendid
added a commit
that referenced
this pull request
Dec 31, 2021
Paddle new APIs: put_along_axis. Xu Huang is on holiday so we created this PR to work on it. It is based on his PR: #37921
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Describe
Paddle new APIs: put_along_axis