[PTen]Add alias kernel name #37881
Merged
[PTen]Add alias kernel name #37881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
paddle/pten/core/convert_utils.cc
Outdated
|
|
||
| namespace pten { | ||
|
|
||
| // the map between kernel name in fluid and pten |
There was a problem hiding this comment.
这里再加些注释，说明一下key，value 是什么含义吧
zyfncg
reviewed
Dec 7, 2021
paddle/pten/core/convert_utils.cc
Outdated
Comment on lines
25
to
35
| {"reshape2", "reshape"}, | ||
| {"fill_any_like", "full_like"}, | ||
| {"fill_constant", "full"}, | ||
| {"matmul_v2", "matmul"}, | ||
| {"flatten_contiguous_range", "flatten"}, | ||
| {"reduce_mean", "mean"}, | ||
| {"reduce_sum", "sum"}, | ||
| {"elementwise_add", "add"}, | ||
| {"elementwise_sub", "subtract"}, | ||
| {"elementwise_mul", "muliply"}, | ||
| {"elementwise_div", "divide"}, |
There was a problem hiding this comment.
这里是不可以按照一个统一的规则排下序，后面迁移的kernel多了找起来也方便
paddle/pten/core/convert_utils.cc
Outdated
| } | ||
| } | ||
|
|
||
| std::string TransToPtenKernelName(const std::string& fluid_op_name) { |
paddle/pten/core/convert_utils.h
Outdated
| using DataType = paddle::experimental::DataType; | ||
| using DataLayout = paddle::experimental::DataLayout; | ||
|
|
||
| std::string TransToPtenKernelName(const std::string& fluid_op_name); |
| const auto* op_proto = pair.second.proto_; | ||
| if (pten::KernelFactory::Instance().HasCompatiblePtenKernel(op_type)) { | ||
| KernelArgsNameMakerByOpProto maker(op_proto); | ||
| VLOG(10) << "Register kernel signature for " << op_type; |
There was a problem hiding this comment.
这里的op_type 是不是也要pten::TransToPtenKernelName(op_type)
chenwhql
reviewed
Dec 7, 2021
| PT_REGISTER_MODULE(CreationCPU); | ||
|
|
||
| PT_REGISTER_KERNEL("fill_any_like", | ||
| PT_REGISTER_KERNEL("full_like", |
There was a problem hiding this comment.
这样直接改会导致pten kernel在运行时都没有被选到吧，兼容态是根据这个名字来搜索是否执行pten kernel的
paddle/pten/core/convert_utils.cc
Outdated
|
|
||
| // the map between kernel name in fluid and pten | ||
| const std::unordered_map<std::string, std::string> kernel_alias_name_map = { | ||
| {"reshape2", "reshape"}, |
There was a problem hiding this comment.
这个会导致咱们让大家迁移的时候，还需要额外关注这个文件的更新和映射，能否在注册时一起声明下这个name
There was a problem hiding this comment.
如果用这种的话，建议这个map单独放到一个文件中管理
MingMingShangTian
approved these changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Add alias kernel name for compatible with old kernel name and modify the kernel name in pten. This will make pten kernel's name more clear.