fix tensor copyfrom bug #3788
Merged
fix tensor copyfrom bug #3788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qingqing01
reviewed
Aug 31, 2017
| boost::get<platform::GPUPlace>(src_place), src_ptr, size, 0); | ||
| } | ||
| PADDLE_ENFORCE(cudaStreamSynchronize(0), | ||
| "cudaStreamSynchronize failed in Tensor CopyFrom"); |
There was a problem hiding this comment.
It's better to move cudaStreamSynchronize to pybind. And it's not good to use 0 as cuda stream in the memory::Copy interface.
There was a problem hiding this comment.
Yes, I will fix it later. And I set up a issue #3796 , try to add a DeviceContextManager to manage CUDA streams appropriately.
heavengate
pushed a commit
to heavengate/Paddle
that referenced
this pull request
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3789