Skip to content

Change _numel func logic and add test #37810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2021
Merged

Change _numel func logic and add test #37810

merged 1 commit into from
Dec 3, 2021

Conversation

veyron95
Copy link
Contributor

@veyron95 veyron95 commented Dec 3, 2021

PR types

Bug fixes

PR changes

APIs

Describe

  1. Removed an unnecessary ENFORCE statement.
  2. Added a relative unit test.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Dec 3, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

JiabinYang
JiabinYang approved these changes Dec 3, 2021
View reviewed changes
Copy link
Contributor

@JiabinYang JiabinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JiabinYang JiabinYang merged commit 075a02d into PaddlePaddle:develop Dec 3, 2021
Zjq9409 pushed a commit to Zjq9409/Paddle that referenced this pull request Dec 10, 2021
@veyron95 @Zjq9409
Fix _numel func logic and add test (PaddlePaddle#37810)
7c04f2f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JiabinYang JiabinYang JiabinYang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@veyron95 @JiabinYang