Skip to content

disable copying of datatype when sharing buffer between two tensors. #37247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 22, 2021
Merged

disable copying of datatype when sharing buffer between two tensors. #37247

merged 6 commits into from
Nov 22, 2021

Conversation

iclementine
Copy link

@iclementine iclementine commented Nov 16, 2021 •
edited
Loading

PR types

Others

PR changes

Others

Describe

  1. Disable copying of datatype when sharing buffer between two tensors. By definition, data type should bot be shared when sharing buffer. Share buffer between real and compex tensor requires this feature.
  2. fix mkldnn op kernels that support inplace computation.(elementwise_add, sum, softmax, softplus, scale, activation)
  3. some code style changes due to code style checking.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@iclementine iclementine mentioned this pull request Nov 17, 2021
Closed
jczaja
jczaja previously approved these changes Nov 19, 2021
View reviewed changes
Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iclementine iclementine requested a review from jczaja November 22, 2021 08:22
luotao1
luotao1 approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for tensor.h

@iclementine
Copy link
Author

@jczaja I've fixed other op kernels you've mentioned in #37306.
So please check this again for the changes to mkldnn operator kernels. Thanks!

@iclementine iclementine merged commit 9ec1432 into PaddlePaddle:develop Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luotao1 luotao1 luotao1 approved these changes

+1 more reviewer

@jczaja jczaja jczaja approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iclementine @luotao1 @jczaja