A better error message for gradient checker #3354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
reyoung
commented
Aug 9, 2017
reyoung
commented
- Give which parameter, which element are wrong. And what max_diff is.
* Give which parameter, which element are wrong. And what max_diff is.
jacquesqiao
reviewed
Aug 9, 2017
| raise ValueError("unknown place " + type(place)) | ||
| self.assertTrue( | ||
| self.__is_close(numeric_grad, scope, max_relative_error), msg) | ||
| self.__is_close(numeric_grad, scope, max_relative_error, |
There was a problem hiding this comment.
要不改成 self.AssertIsClose ?
这个函数实际上干了Assert的事儿，而不是判断是不是 close
jacquesqiao
approved these changes
Aug 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.