Skip to content

modify complex template for elementwise ops #33071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 25, 2021
Merged

modify complex template for elementwise ops #33071

merged 6 commits into from
May 25, 2021

Conversation

@MingMingShangTian
Copy link
Contributor

@MingMingShangTian MingMingShangTian commented May 24, 2021 •
edited
Loading

PR types

Others

PR changes

OPs

Describe

  • Replace complex64/128 with complex<float/double> in elementwise_add, elementwise_sub, elementwise_mul, elementwise_div ops.
  • Remove the useless codes in CudaShuffleDownSync and CudaShuffleXorSync functions which was remained when removing CUDA9.0 codes in the PR31883

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

chenwhql
chenwhql reviewed May 25, 2021
View reviewed changes
paddle/fluid/platform/cuda_device_function.h
#define PADDLE_CUDA_FP16
#include "paddle/fluid/platform/complex128.h"
#include "paddle/fluid/platform/complex64.h"
#include "paddle/fluid/platform/complex.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this need in #define PADDLE_CUDA_FP16?

chenwhql
chenwhql approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MingMingShangTian MingMingShangTian merged commit dbc08d6 into PaddlePaddle:develop May 25, 2021
@MingMingShangTian MingMingShangTian deleted the template_elementwise_ops branch May 25, 2021 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenwhql chenwhql chenwhql approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MingMingShangTian @chenwhql