use isclose instead of assert_almost_equal #3248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangkuiyi
approved these changes
Aug 4, 2017
wangkuiyi
reviewed
Aug 4, 2017
| # has some diff, and could not pass unittest. So I set decimal 3 here. | ||
| # And I will check this in future. | ||
| numpy.testing.assert_almost_equal(actual, expect, decimal=3) | ||
| numpy.isclose(actual, expect) |
There was a problem hiding this comment.
It seems that numpy.isclose compares the relative difference, and numpy.testing.assert_almost_equal compares the absolute difference. Why should we use relative other than absolute difference here?
There was a problem hiding this comment.
An error of 0.00001 is appropriate for numbers around one, too big for numbers around 0.00001, and too small for numbers around 10,000. A more generic way of comparing two numbers – that works regardless of their range, is to check the relative error. Relative error is measured by comparing the error to the expected result.
Please refer to http://www.cygnus-software.com/papers/comparingfloats/Comparing%20floating%20point%20numbers.htm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numpy.isclose:
numpy.testing.assert_almost_equal:
isclose is more appropriate for comparing two floats.