Add golang precommit #2748
Add golang precommit #2748
Conversation
… add_golang_precommit
| @@ -1,6 +1,6 @@ | |||
| cc_library(paddle_go_optimizer DEPS paddle_optimizer paddle_proto glog gflags protobuf) | |||
| target_link_libraries(paddle_go_optimizer stdc++ m) | |||
There was a problem hiding this comment.
if we add them here, can our cgo part remove the -lstdc++ -lm ldflags?
There was a problem hiding this comment.
No, we can't. Seems linking does not put symbols and implements inside the lib.
| COMMAND rm "${${TARGET_NAME}_LIB_PATH}" | ||
| # Golang build source code | ||
| COMMAND env LIBRARY_PATH=${CMAKE_BINARY_DIR}/go/pserver/client/c/:$ENV{LIBRARY_PATH} GOPATH=${GOPATH} ${CMAKE_Go_COMPILER} build ${BUILD_MODE} | ||
| COMMAND GOPATH=${GOPATH} ${CMAKE_Go_COMPILER} build ${BUILD_MODE} |
There was a problem hiding this comment.
: ) this may be the correct way to go. Put fixed path into generic.cmake seems dangerous, and we may forget these mess as days go by.
|
Thanks for the golang CI! |
|
Need to fix teamcity issue so we can test and merge. |
…/Paddle into add_golang_precommit
| script: | ||
| - | | ||
| export WITH_GOLANG=ON && timeout 2580 paddle/scripts/travis/${JOB}.sh # 43min timeout | ||
| timeout 2580 paddle/scripts/travis/${JOB}.sh # 43min timeout |
There was a problem hiding this comment.
so we still stop the go lang compile on Travis-ci?
There was a problem hiding this comment.
Must pass -DWITH_GLANG=ON to cmake, export won't turn on the swith.
There was a problem hiding this comment.
got it, thanx~ so this means yesterday golang was not compiled on Travis-ci...
… add_golang_precommit
4 participants
Add golang pre-commit and fix travis build configs
Found a related PR: #2745