Skip to content

Conversation

Superjomn
Copy link
Contributor

@Superjomn Superjomn commented Jun 10, 2018

339/342 Test #341: inference_anakin_test ...........................   Passed    5.22 sec

@Superjomn Superjomn requested a review from luotao1 June 10, 2018 08:55
option(WITH_ARM_FP16 "Use half precision support on armv8.2-a cpu" OFF)
option(WITH_FAST_BUNDLE_TEST "Bundle tests that can be run in a single process together to reduce launch overhead" OFF)
option(WITH_CONTRIB "Compile the third-party contributation" OFF)
option(WITH_ANAKIN "Compile with Anakin library" OFF)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci里要设成ON,测一下么?可以修改paddle_build.sh

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already set in paddle_build.sh


if (NOT WITH_GPU)
set(WITH_ANAKIN OFF CACHE STRING "Anakin is valid only when GPU is set." FORCE)
endif()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

184-192

if(WITH_GPU)
     include(cuda)
     include(tensorrt)
     include(external/anakin)
else()
      set(WITH_ANAKIN OFF CACHE STRING "Anakin is valid only when GPU is set." FORCE)
endif()

@@ -0,0 +1,41 @@
if (NOT WITH_ANAKIN)
return()
endif()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1-3可以去掉。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

下面会 wget anakin 的库,如果没有打开可以忽略所有下面的逻辑。

fetch_include_recursively(${root_dir}/${sub})
endif()
endforeach()
endfunction()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以用ExternalProject_Add来写,会更加清晰和统一。不用自己写function了。参考:mklml.cmake

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有时间的话在另外一个 pr 里加吧。

@Superjomn Superjomn requested a review from panyx0718 June 14, 2018 01:24
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Superjomn Superjomn merged commit bd2a537 into PaddlePaddle:develop Jun 14, 2018
@Superjomn Superjomn deleted the feature/anakin-ci branch June 14, 2018 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants