Skip to content

Conversation

@AlbertVan
Copy link
Contributor

…t=develop

@paddle-bot
Copy link

paddle-bot bot commented Jul 17, 2022

Thanks for your contribution!

@xiehanlin
Copy link
Collaborator

LGTM

Copy link
Contributor

@liyancas liyancas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weishengying
Copy link
Collaborator

LGTM

// **DEPRECATED**, use set_xpu_l3_cache_method() in the future
void set_xpu_workspace_l3_size_per_thread(int l3_size = 0x4000000);
void set_xpu_l3_cache_method(size_t l3_size, bool locked = false);
void set_xpu_l3_cache_autotune(bool autotune = true);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是公开api吗,公开api 需要补到C++ 文档中

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

并补充相关单测到paddle_api_test.cc

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

相关的python API 需要考虑是否补充

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

收到,该接口的使用说明在下个pr中补充

@DannyIsFunny
Copy link
Collaborator

LGTM

std::vector<LoD> last_input_lods_{};
std::vector<DDimLite> last_output_shapes_{};
std::vector<LoD> last_output_lods_{};
// last shape tensor vector cache.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  std::vector<DDimLite> last_input_shapes_{};
  std::vector<LoD> last_input_lods_{};
  std::vector<DDimLite> last_output_shapes_{};
  std::vector<LoD> last_output_lods_{};

子类里为什么要重新声明这四个成员变量,为什么不直接使用 OperatorBase 基类里声明的同名变量

Copy link
Collaborator

@hong19860320 hong19860320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhupengyang zhupengyang merged commit dfd2b28 into PaddlePaddle:develop Jul 19, 2022
@AlbertVan AlbertVan deleted the my-cool-stuff branch August 5, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants