[BugFix][OpenCL] Fix concat image impl when axis is not 1. test=develop #4241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaoyang-star
changed the title
zhaoyang-star
dismissed stale reviews from chenjiaoAngel, xiebaiyuan, and ysh329
via
656cb45
zhaoyang-star
added a commit
to zhaoyang-star/Paddle-Lite
that referenced
this pull request
Sep 14, 2020
…op (PaddlePaddle#4241) * [BugFix][OpenCL] Fix concat image impl when concat axis is not 1 * fix code when axis == 1. test=develop * fix illegal access when print debug info. test=develop * fix typo
zhaoyang-star
added a commit
to zhaoyang-star/Paddle-Lite
that referenced
this pull request
Sep 24, 2020
…op (PaddlePaddle#4241) * [BugFix][OpenCL] Fix concat image impl when concat axis is not 1 * fix code when axis == 1. test=develop * fix illegal access when print debug info. test=develop * fix typo
juncaipeng
pushed a commit
to juncaipeng/Paddle-Lite
that referenced
this pull request
Oct 27, 2020
…op (PaddlePaddle#4241) * [BugFix][OpenCL] Fix concat image impl when concat axis is not 1 * fix code when axis == 1. test=develop * fix illegal access when print debug info. test=develop * fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
【问题1】当 concat 的 axis 不为 1 时，opencl concat image 实现计算错误。
【原因】在成员函数
PrepareForRun中定义了一个临时变量axis_（该临时变量与类的成员变量axis_重名），在PrepareForRun中对临时变量的赋值并不会传递到成员函数Run中，因此在Run中读取的axis_值恒为默认值。【解决方法】删除成员函数
PrepareForRun中对axis_的定义，改为直接对成员变量axis_赋值。【问题2】当 concat 的 axis 为 -1 时，opencl concat image 实现计算错误且有内存越界现象。
【原因】当 axis==-1时，需要对其进行转换。
【解决方法】将 axis 置为 output 的最后一个 axis。
【其他】修改了输出debug信息时存在的内存越界访问。