-
Notifications
You must be signed in to change notification settings - Fork 217
Adding MSG_NAV_HPPOSLLH for high precision RTK positioning #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: gps_position message uses raw uint32 fro lat and lon, so I had to use alt_ellipsoid to pass high precision components
Requires changes to .../PX4-Autopilot/msg/SensorGps.msg: # RTK GPS high precision components: int8 lat_hp # Latitude high precision component, -99 to +99 in 1E-9 degrees int8 lon_hp # Longitude high precision component, -99 to +99 in 1E-9 degrees int8 alt_hp # high precision component of altitude above mean sea level, -9 to +9 in 0.1 mm int8 alt_ellipsoid_hp # high precision component of altitude above Ellipsoid, -9 to +9 in 0.1 mm
WIP: back to one config message for Rover USB RELPOSNED and HPPOSLLH
Removed tracing, version ready for PR
Restored original order in _got_posllh / _got_velned
Original whitespace restored
|
I opened PX4/PX4-Autopilot#21678 to match these changes (specifically, to add lines to SensorGps.msg) |
|
See #136 for further action |
bkueng
pushed a commit
to PX4/PX4-Autopilot
that referenced
this pull request
Jul 13, 2023
To match PX4/PX4-GPSDrivers#132 - adding high precision RTK lat/lon/alt components
antbre
pushed a commit
to BioMorphic-Intelligence-Lab/PX4-Autopilot
that referenced
this pull request
Sep 14, 2023
To match PX4/PX4-GPSDrivers#132 - adding high precision RTK lat/lon/alt components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently LAT/LON/ALT values come mostly from UBX_MSG_NAV_PVT message, which does not deliver high precision components to _gps_position ORB message (a.k.a. SensorGps.msg).
This PR seeks to add parsing of the MSG_NAV_HPPOSLLH message and delivering high precision components of the coordinates to the PX4 codebase.
My code works fine on my rover, removing random jerking which was caused by low precision "rounding" of the coordinates. With centimeter accuracy my rover (lawnmower) moves smoothly and precisely, which is critical for agricultural vehicles.
I have dual antenna F9P configuration and also take advantage of precise heading (RELPOSNED).
Here is the code that utilizes the added fields:
I'd guess that the added components must be also passed to EKF2 for better estimates. It could also prioritize RTK precision data, when available.
Note:
The following block must be added to PX4-Autopilot/msg/SensorGps.msg, to generate sensor_gps_s structure: