Skip to content

Commit c94e076

Browse files
committed
mavlink: don't silently ignore mavlink dev streams
I don't think it makes sense to ignore required streams that easily. If we do use some streams that are only in the MAVLink development.xml dialect, then we will have to properly and explicitly ifdef them everywhere that we use them. Otherwise, this basically means that we will just swallow this warning on most (non mavlink-dev) platforms which can mask issues.
1 parent 4498475 commit c94e076

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/modules/mavlink/mavlink_main.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1194,8 +1194,8 @@ Mavlink::configure_stream(const char *stream_name, const float rate)
11941194
}
11951195

11961196
// if we reach here, the stream list does not contain the stream.
1197-
// flash constrained target's don't include all streams, and some are only available for the development dialect
1198-
#if defined(CONSTRAINED_FLASH) || !defined(MAVLINK_DEVELOPMENT_H)
1197+
// flash constrained target's don't include all streams
1198+
#if defined(CONSTRAINED_FLASH)
11991199
return PX4_OK;
12001200
#else
12011201
PX4_WARN("stream %s not found", stream_name);

0 commit comments

Comments
 (0)