🪲 [Fix]: Remove preserve-credential on checkout #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and configuration logging
… Update-FontsData workflow
…figuration in Update-FontsData script
MariusStorhaug
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
Module NerdFonts - v1.0.19 published to the PowerShell Gallery. |
|
GitHub release for NerdFonts v1.0.19 has been created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes changes to the
Update-FontsDataworkflow and script to improve security and functionality. The most important changes include updating the GitHub Actions workflow to avoid persisting credentials and modifying the PowerShell script to use a default connection for the GitHub App.Improvements to security and functionality:
.github/workflows/Update-FontsData.yml: Updated theCheckout repositorystep to avoid persisting credentials by settingpersist-credentialstofalse.scripts/Update-FontsData.ps1: Modified theConnect-GitHubAppcommand to use the-Defaultparameter for a default connection.Type of change
Checklist