chore: bump sqlformat from 0.3.5 to 0.4.0 #5441
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [sqlformat](https://github.com/shssoichiro/sqlformat-rs) from 0.3.5 to 0.4.0. - [Release notes](https://github.com/shssoichiro/sqlformat-rs/releases) - [Changelog](https://github.com/shssoichiro/sqlformat-rs/blob/master/CHANGELOG.md) - [Commits](shssoichiro/sqlformat-rs@v0.3.5...v0.4.0) --- updated-dependencies: - dependency-name: sqlformat dependency-version: 0.4.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
|
@claude fix the test expectations; iterate with CI until CI passes |
|
Claude finished @max-sixty's task —— View job ✅ Fixed test expectations for sqlformat 0.4.0CI is currently running with the latest fixes. I've updated the test expectations to match the new SQL formatting from sqlformat 0.4.0. Completed Tasks:
Summary of Changes (3 commits):
Test Status Progress:
The main formatting changes from sqlformat 0.4.0:
🔗 View CI runs | |
Update inline snapshots and test expectations to match the new formatting from sqlformat 0.4.0: - UNION ALL, INTERSECT ALL, EXCEPT ALL now on single line - WITH table_X AS formatting adjusted - SELECT DISTINCT formatting changes - Various parenthesis placement adjustments Co-authored-by: Maximilian Roos <[email protected]>
- Fix PARTITION BY formatting for window functions - Adjust parenthesis placement in CTEs - Fix ROW_NUMBER() OVER formatting Co-authored-by: Maximilian Roos <[email protected]>
- Fix WITH table formatting - Fix REGEXP spacing - Additional PARTITION BY fixes Co-authored-by: Maximilian Roos <[email protected]>
- Reduce CTE indentation from 6 to 2 spaces - Update closing parenthesis placement - Fix SELECT indentation Co-authored-by: Maximilian Roos <[email protected]>
Updates test snapshots to match sqlformat 0.4.0's formatting changes: - Simple SELECT statements now use 4-space indentation (was 2-space) - Consistent formatting across all test files 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Updates test expectations to match sqlformat 0.4.0's formatting: - Closing parenthesis after subquery stays on same line as NULL - Fixes test-python and test-elixir CI failures 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
# Conflicts: # prqlc/prqlc/Cargo.toml
sqlformat 0.4.0 requires Rust 1.84.0 as its minimum supported version
sqlformat 0.4.0 requires Rust 1.84.0 which is too large of a jump from our current MSRV of 1.75.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps sqlformat from 0.3.5 to 0.4.0.
Changelog
Sourced from sqlformat's changelog.
Commits
f910e6fVersion 0.4.0b251c7cfix: Place a whitespace between the array type specifier and a reserved word7d3ae8cfeat: Consistently space blocks after arguments1ce0359feat: Correctly inline opening parentheses (#100)d20763cSupport more conditionally top level tokens (#99)227688fchore(deps): bump actions/checkout from 4 to 5a14692edocs: update the Readme to be more usefulfd28063docs: add rules for Cursor7b9d239chore(deps): update criterion requirement in the rust-dependencies group5e7146fci: add code coverage and modernize cachingYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)