-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Achievements: Separate token into its own secrets.ini file #13102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a thorough review, just some stuff that I noticed.
Made some adjustments per chaotic's feedback. Token should now remove itself from the main file if already present, secrets.ini should auto generate when it does so on boot. Also fixed the function mixup, added timer and mutex, and generally made it a bit cleaner, and I think properly locking said mutex now. |
Description of Changes
Creates a separate secrets.ini file for storing sensitive or privileged information. Adds the RetroAchievements login token to this file, removing it from the base PCSX2.ini.
Please give this one a very thorough grilling on code review, I do not know if I did this right, I probably have some kind of unsafe access somewhere, something something threading and locks and internal vs external core/host stuff.
Rationale behind Changes
Makes it safer to share actual settings ini files without potentially compromising RetroAchievements sessions tokens.
Suggested Testing Steps
Try logging in to RetroAchievements, verify your login is respected across restarts, check if your token is still present in your old PCSX2.ini file (this one might need a separate action to remove but I'm not sure how we go about that, tbd).
Did you use AI to help find, test, or implement this issue or feature?
No, and I'm not angry, just disappointed that we have to ask people.