FSUI: Add Network and HDD settings page #12938

SternXD · 2025-07-01T06:32:32Z

Description of Changes

This PR adds a complete Network and HDD settings page to FullscreenUI, bringing feature parity with the Qt interface for DEV9. This includes:

Ethernet device type selection with proper adapter availability checking (PCAP, TAP, Sockets)
Ethernet device dropdown with network adapter enumeration and friendly names
Complete network configuration options (IP address, subnet mask, gateway, DNS settings)
DHCP interception toggle and related network settings
HDD image file selection via directory picker with automatic filename generation
HDD creation functionality with progress dialog and proper size validation
LBA48 toggle for large HDD support

Rationale behind Changes

Previously, users had to exit FullscreenUI and use the Qt interface to configure network and HDD settings for DEV9. This created an inconsistent user experience and made it a horrible experience for anyone couch gaming.

The changes solve this by:

Providing complete DEV9 configuration within FullscreenUI
Using similar adapter detection logic as Qt to only show available network types
Implementing proper HDD size limits (40-120GB for LBA28, 100-2000GB for LBA48)

Suggested Testing Steps

Network Settings:
- Verify only available adapter types appear in Ethernet Device Type dropdown
- Test adapter selection shows friendly names and updates correctly
- Confirm network settings (IP, DNS, etc.) save and load properly
- Test DHCP toggle enables/disables related settings appropriately
HDD Settings:
- Test HDD image file selection creates proper path with DEV9hdd.raw filename
- Verify HDD creation with different sizes and LBA modes
- Confirm size limits enforce correctly (40-120GB LBA28, 100-2000GB LBA48)
- Test progress dialog during HDD creation
Cross-Platform:
- Test on Windows (should show TAP if available) and Linux/macOS (I will test macOS once it builds)
- Verify adapter enumeration works correctly on different platforms

Did you use AI to help find, test, or implement this issue or feature?

I did not use it for my code but it did help me with grammar and better helping understand why this should be added.

TheLastRar · 2025-07-02T19:39:28Z

Tested only Windows, and haven't done a code review

In Qt, the API is set only when a valid adapter is selected
This PR currently sets it whenever the API is changed

I cannot select the device when sockets is set.
The list of PCAP adapters don't use the same friendly names that Qt uses (and also a different amount of adapters?).
The list of TAP adapters is incorrect.

I cannot adjust the DNS settings under sockets when Internet DHCP has been disabled (for other API types)
The value of Internet DHCP should be ignored when DHCP_ForcedOn is returned from GetAdapterOptions()

IP input boxes lack much of the styling styling that other popups have
Maybe take inspiration from the OSD scale editor (after clicking the keyboard icon for text input)

Min & default HDD size should be 40GB

HDD input boxes lack much of the styling that other popups have
See similar comment regarding IP boxes
If you want a slider you can take inspiration from the volume sliders, but the option for text input should be preserved

The LBA48 setting is a fake setting (it isn't saved anywhere)
In Qt, it sets the limits for the slider/validations
Core will enable/disable it based on the file size

The HDD section does not display the existing file (See Bios for example)

The existing file size is not displayed either (differing from Qt)
IIRC it became a 'fake' setting like LBA48 at some point

SternXD · 2025-07-02T19:40:56Z

Okay I will look into that all for you right now and fix them 🫡

TheLastRar

Quick code review of the changes in FullscreenUI only

As for (Windows) testing

Vertical spacing for the IP address isn't consistent between display and edit in the IP address popup
You could immediately show the edit box rather then having to click a button (given you don't spinner arrows that the OSD scale popup has)
otherwise, styling looks correct.

When switching to pcap or tap, you default to Auto
Auto isn't a valid setting (at least on windows) for these adapters
The Qt UI attempts to match to the same adapter if it can, but if that is too difficult you can just clear it.

Changing the HDD directory didn't seem to work.
The custom HDD size input popup is not styled correctly.

I had originally intended inis to be the default directory for Hdd
Core defaults to ini if only a filename is set, but it seems that the Qt's file picker defaults to documents/PCSX2 directory instead.
The default directory you've picked is probably the one that people actually end up using, so seems the better pick.

pcsx2/ImGui/FullscreenUI.cpp

pcsx2/ImGui/FullscreenUI.h

pcsx2/ImGui/FullscreenUI.cpp

Signed-off-by: SternXD <[email protected]> .

TheLastRar

Selecting an existing HDD via browse doesn't close the file picker
The file picker probably should show only .raw files

The text box for saving an input profile is a different colour in this PR vs master.

TheLastRar · 2025-07-13T18:44:12Z

pcsx2/ImGui/FullscreenUI.cpp

+				else if (!previous_device.empty() && index < static_cast<s32>(current_adapter_lists.size()))
+				{
+					const auto& new_adapter_list = current_adapter_lists[index];
+					const auto& old_adapter_list = current_adapter_lists[0];


old_adapter_list doesn't appear to be used

TheLastRar · 2025-07-13T18:52:34Z

pcsx2/ImGui/FullscreenUI.cpp

+					{
+						for (const auto& adapter : new_adapter_list)
+						{
+							if (adapter.name == old_adapter_name)


Is there a reason you aren't matching based on GUID?

TheLastRar · 2025-07-13T19:12:00Z

pcsx2/ImGui/FullscreenUI.cpp

+	// Get device display name
+	std::string device_display = "Auto";
+	if (show_device_setting && !current_device.empty())
+	{
+		// Get the adapter list for current API type
+		if (current_api_index < adapter_lists.size())
+		{
+			const auto& adapter_list = adapter_lists[current_api_index];
+			for (const auto& adapter : adapter_list)
+			{
+				if (adapter.guid == current_device)
+				{
+					device_display = adapter.name;
+					break;
+				}
+			}
+		}
+
+		if (device_display == "Auto")
+			device_display = current_device;
+	}
+	else if (show_device_setting && current_device.empty())
+	{
+		const std::string current_api = bsi->GetStringValue("DEV9/Eth", "EthApi", "Unset");
+		if (current_api == "PCAP Bridged" || current_api == "PCAP Switched" || current_api == "TAP")
+		{
+			device_display = "Not Selected";
+		}
+	}


IIRC, Sockets doesn't default to Auto when nothing is selected, instead, a GUID of Auto needs to be in the config.
Thus, "Not Selected" should be displayed for all adapters when current_device is an empty string.

TheLastRar · 2025-07-13T20:00:19Z

pcsx2/ImGui/FullscreenUI.cpp

@@ -2867,6 +3030,115 @@ void FullscreenUI::DrawPathSetting(SettingsInterface* bsi, const char* title, co
 	}
 }

+void FullscreenUI::DrawTextSetting(SettingsInterface* bsi, const char* title, const char* summary, const char* section, const char* key,


Is this function used anywhere?

TheLastRar · 2025-07-13T20:06:46Z

pcsx2/ImGui/FullscreenUI.cpp

+	ImGui::PushFont(g_large_font.first, g_large_font.second);
+	ImGui::PushStyleVar(ImGuiStyleVar_WindowRounding, LayoutScale(10.0f));
+	ImGui::PushStyleVar(ImGuiStyleVar_WindowPadding, LayoutScale(20.0f, 20.0f));
+	ImGui::PushStyleVar(ImGuiStyleVar_FrameBorderSize, 0.0f);
+	ImGui::PushStyleVar(ImGuiStyleVar_FramePadding,
+		LayoutScale(ImGuiFullscreen::LAYOUT_MENU_BUTTON_X_PADDING, ImGuiFullscreen::LAYOUT_MENU_BUTTON_Y_PADDING));
+
+	bool is_open = true;
+	if (ImGui::BeginPopupModal(title, &is_open, ImGuiWindowFlags_NoCollapse | ImGuiWindowFlags_NoResize | ImGuiWindowFlags_NoMove))
+	{
+		BeginMenuButtons();
+
+		bool value_changed = false;
+		char ip_str[16];
+		std::snprintf(ip_str, sizeof(ip_str), "%d.%d.%d.%d", ip_octets[0], ip_octets[1], ip_octets[2], ip_octets[3]);
+
+		const float end = ImGui::GetCurrentWindow()->WorkRect.GetWidth();
+		ImGui::SetNextItemWidth(end);
+		if (ImGui::InputText("##ip", ip_str, sizeof(ip_str), ImGuiInputTextFlags_CharsDecimal | ImGuiInputTextFlags_CallbackCharFilter,
+			[](ImGuiInputTextCallbackData* data) -> int {
+				// Only allow digits and dots
+				return (data->EventChar >= '0' && data->EventChar <= '9') || data->EventChar == '.' ? 0 : 1;
+			}))
+		{
+			std::istringstream iss(ip_str);
+			std::string segment;
+			int i = 0;
+			while (std::getline(iss, segment, '.') && i < 4)
+			{
+				ip_octets[i] = std::clamp(std::atoi(segment.c_str()), 0, 255);
+				i++;
+			}
+			value_changed = true;
+		}
+		ImGui::SetCursorPosY(ImGui::GetCursorPosY() + LayoutScale(10.0f));
+
+		if (value_changed)
+		{
+			std::snprintf(ip_str, sizeof(ip_str), "%d.%d.%d.%d", ip_octets[0], ip_octets[1], ip_octets[2], ip_octets[3]);
+			if (IsEditingGameSettings(bsi) && strcmp(ip_str, default_value) == 0)
+				bsi->DeleteValue(section, key);
+			else
+				bsi->SetStringValue(section, key, ip_str);
+			SetSettingsChanged(bsi);
+		}
+
+		if (MenuButtonWithoutSummary(FSUI_CSTR("OK"), true, LAYOUT_MENU_BUTTON_HEIGHT_NO_SUMMARY, g_large_font, ImVec2(0.5f, 0.0f)))
+		{
+			ImGui::CloseCurrentPopup();
+		}
+		EndMenuButtons();
+		ImGui::EndPopup();
+	}
+
+	ImGui::PopStyleVar(4);
+	ImGui::PopFont();


Our existing code would have popup logic in ImGuiFullscreen (via Open*,Is*Open,Close, with Draw being called ImGuiFullscreen::EndLayout()

I would prefer if this new code was consistent (i.e. creating *IPAddressDialog functions)

TheLastRar · 2025-07-13T20:35:08Z

pcsx2/ImGui/ImGuiFullscreen.cpp

+		ImGui::SetNextItemWidth(text_box_size.x - 10.0f);
+
+		// Check if we're in an IP address or numeric input field
+		bool is_ip_input = s_input_dialog_message.find("xxx.xxx.xxx.xxx") != std::string::npos;


I don't think you are using OpenInputStringDialog() for IP addresses now

I now notice that you this was what you originally used for the IP dialogs.
This only got used for naming an input profile dialog was, which I didn't open when comparing dialogs back when I mentioned styling.

TheLastRar · 2025-07-13T20:37:30Z

pcsx2/ImGui/ImGuiFullscreen.cpp

@@ -2172,7 +2172,7 @@ bool ImGuiFullscreen::IsFileSelectorOpen()
 }

 void ImGuiFullscreen::OpenFileSelector(std::string_view title, bool select_directory, FileSelectorCallback callback,
-	FileSelectorFilters filters, std::string initial_directory)
+	FileSelectorFilters filters, std::string initial_directory, std::string default_filename)


This new parameter isn't used

TheLastRar · 2025-07-13T20:58:15Z

pcsx2/ImGui/FullscreenUI.cpp

+								OpenInputStringDialog(
+									FSUI_ICONSTR(ICON_FA_PEN_TO_SQUARE, "Custom HDD Size"),
+									FSUI_STR("Enter custom HDD size in gigabytes (40-2000):"),
+									"40",


Is this supposed to be the default value?, because that argument is for a caption

TheLastRar · 2025-07-13T21:05:22Z

pcsx2/ImGui/ImGuiFullscreen.cpp

+
+		// Check if we're in an IP address or numeric input field
+		bool is_ip_input = s_input_dialog_message.find("xxx.xxx.xxx.xxx") != std::string::npos;
+		bool is_numeric_input = s_input_dialog_message.find("gigabytes") != std::string::npos;


Perhaps OpenInputStringDialog() could accept a callback or enum/bool for input filtering, rather then guessing based on the dialog title.

SternXD · 2025-07-17T08:04:24Z

Will work on the fixes and stuff later taking a little break from PCSX2 dev

SternXD force-pushed the fsui-network&hdd branch 2 times, most recently from c0b4728 to 3495a8e Compare July 1, 2025 07:36

SternXD marked this pull request as draft July 1, 2025 09:40

SternXD force-pushed the fsui-network&hdd branch 2 times, most recently from 1be676b to ad1374c Compare July 1, 2025 10:09

SternXD marked this pull request as ready for review July 1, 2025 10:21

JordanTheToaster added this to the Release 2.6 milestone Jul 2, 2025

SternXD force-pushed the fsui-network&hdd branch 4 times, most recently from 9061651 to bd9be20 Compare July 3, 2025 10:06

TheLastRar reviewed Jul 3, 2025

View reviewed changes

SternXD force-pushed the fsui-network&hdd branch 2 times, most recently from 7e78dae to f5d031a Compare July 6, 2025 18:09

lightningterror added the Needs Rebase label Jul 11, 2025

SternXD force-pushed the fsui-network&hdd branch from f5d031a to eff9ae2 Compare July 11, 2025 19:30

Mrlinkwii added GUI/Qt and removed Needs Rebase labels Jul 11, 2025

TheTechnician27 added OSD / ImGui and removed GUI/Qt labels Jul 11, 2025

FSUI: Add Network and HDD settings page

47b21b5

Signed-off-by: SternXD <[email protected]> .

SternXD force-pushed the fsui-network&hdd branch from eff9ae2 to 47b21b5 Compare July 12, 2025 20:04

JordanTheToaster requested a review from TheLastRar July 13, 2025 12:42

TheLastRar reviewed Jul 13, 2025

View reviewed changes

SternXD marked this pull request as draft July 17, 2025 08:03

Uh oh!

FSUI: Add Network and HDD settings page #12938

Are you sure you want to change the base?

FSUI: Add Network and HDD settings page #12938

Conversation

SternXD commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Changes

Rationale behind Changes

Suggested Testing Steps

Did you use AI to help find, test, or implement this issue or feature?

Uh oh!

TheLastRar commented Jul 2, 2025

Uh oh!

SternXD commented Jul 2, 2025

Uh oh!

TheLastRar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TheLastRar left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SternXD commented Jul 17, 2025

Uh oh!

Uh oh!

SternXD commented Jul 1, 2025 •

edited

Loading