-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Qt: Add Custom background support #12722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
In future we could add a customisable dark filter on top for easier reading gamelist itself in as a sort of pseudo dropshadow that movie subtitles would do. The current form limits the usecase to less viable screenshots. But it's good for now to add some more personality (or make people crazy with meme images) |
Yeah i do hope to add some kind of brightness/opacity option (or drop shadow for texts if viable) and cropping mode in the future. |
I remember I previously said this could be implemented by subclassing QStackedWidget and overriding the paint event. I think I may have been overthinking that, A few things I noticed:
|
Whoops you were right, that check was too aggressive. I'll fix it later.
I'm not sure how to reach the |
I've done some testing and I can't seem to get it to work with the palette method either, I'm not sure why. I think subclassing QStackedWidget and drawing the pixmap in the paintEvent function should still work though. Just make sure to use drawTiledPixmap and pass in the invalidated region. You'll need to disable autoFillBackground on the viewports (e.g. |
4827654
to
ae136d7
Compare
I wonder if it could be possible to add support for animated webps (in a future PR). It would be quiet nice to have! Gif works too but gif is yucky |
I don't think Qt can do that. |
What if you decode the frames manually then update the background every few ms from a worker thread? 🤔 |
169b712
to
dd3311a
Compare
Animated WEBP and GIF now works! 2025-06-08.14-51-36.mp4 |
NO WAY :0, I will test that later this day! |
a6b0a8c
to
9307c0b
Compare
77d3499
to
cf39fc9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested both gif and png as background , both worked well on the appimage , needs macos /flatpak testing
Its not a bug, its a feature.
|
APNG support has been added courtesy of @TheLastRar ! also has been re-tested on Linux and macOS: ![]() |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found that the animation doesn't stop when "Render to Separate Window" is enabled while the VM is running.
I also find that putting all of these options in the View
menu with no way to configure them in our normal settings window ends up awkward.
I usually go in blind at first when testing PRs, trying to match the knowledge of a new PCSX2 user. I couldn't find the setting and had to refer to the testing steps.
f21f269
to
60b0ac0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ui options should be put in Interface, would fit better there.
Ideally in the Preferences section.
I'd recommend waiting for #13066 and rebasing on top of that then, just to minimize merge conflicts (otherwise you'd need to add another scroll area manually, since with the auto updater group box shown there's no space). |
60b0ac0
to
cd391d1
Compare
Qt: Make sure custom background aren't active when game list isn't shown To save on CPU Power and be more efficient Co-Authored-By: TheLastRar <[email protected]>
Needed for animated WEBPs to work on Windows. Co-Authored-By: TheLastRar <[email protected]>
Co-Authored-By: TheLastRar <[email protected]>
cd391d1
to
32ef5f5
Compare
Description of Changes
This PR adds the ability to set custom background on the game list.
Preview:




Rationale behind Changes
Nice eye-candy and more customizations
Suggested Testing Steps
To set a custom image:
View -> Set Custom Background
Things to test:
Known issues so far:
The background doesn't get cleared automatically when clearing the custom backgroundUnreadable text when using bright backgroundsDid you use AI to help find, test, or implement this issue or feature?
Nuh-uh