Fix Multi Screen Bug #1189
Merged
Fix Multi Screen Bug #1189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eviously saved on cache
| # Restore the window configuration if the screen in cache is not available | ||
| if (DisplayServer.get_screen_count() | ||
| < (Global.config_cache.get_value("window", "screen") + 1)): | ||
| return |
There was a problem hiding this comment.
Not too sure about the return here, that will prevent the rest of the method code from executing. I think a better solution may be doing this:
var screen = Global.config_cache.get_value("window", "screen")
if DisplayServer.get_screen_count() >= screen + 1:
get_window().current_screen = screen
There was a problem hiding this comment.
My first attempt was this one, but if the external monitor resolution is different than the current, the position may be a problem too.
In my case even if the screen was correct, the laptop resolution differ from the external one, that's why i've chosen to not apply any of the cache values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1188