-
Notifications
You must be signed in to change notification settings - Fork 12.3k
docs: fix ERC165 docs and ERC165Checker references #6076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: typo-fixes
Are you sure you want to change the base?
docs: fix ERC165 docs and ERC165Checker references #6076
Conversation
|
WalkthroughThis pull request updates documentation in the utilities module. The Possibly related PRs
Suggested labels
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (1)📚 Learning: 2025-08-28T16:58:18.879ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Updated utilities.adoc Introspection section to remove outdated _registerInterface(bytes4) guidance for ERC165 and instruct overriding supportsInterface(bytes4) with super.supportsInterface chaining.
Corrected ERC165Checker method references from _supportsInterface/_supportsAllInterfaces to supportsInterface/supportsAllInterfaces, and added references to supportsERC165 and getSupportedInterfaces.
The previous documentation reflected legacy patterns and method names not present in the current codebase. The changes align docs with the current implementations in ERC165.sol and ERC165Checker.sol, preventing user confusion.
npx changeset add)