fix: ClashingImplementation comment to reference upgradeToAndCall

[radik878]

ClashingImplementation is used to test selector clash behavior of TransparentUpgradeableProxy. The proxy’s external interface exposes upgradeToAndCall(address,bytes) (see ITransparentUpgradeableProxy and _fallback()), not changeAdmin(address). The previous comment referenced changeAdmin(address), which is only an internal utility in ERC1967Utils and not part of the proxy’s external interface.

[changeset-bot]

⚠️ No Changeset found

Latest commit: ff77150

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The documentation comment in the ClashingImplementation.sol contract was updated to accurately reflect the contract's purpose. The comment now describes a payable upgradeToAndCall(address,bytes) function that clashes with TransparentUpgradeableProxy's interface, replacing the previous reference to a payable changeAdmin(address) function. The contract's actual function implementations, control flow, and public declarations remain unchanged.

Suggested labels

typo

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: updating a comment in ClashingImplementation to reference the correct function (upgradeToAndCall instead of changeAdmin).
Description check	✅ Passed	The description clearly explains the purpose of ClashingImplementation, identifies the issue with the previous comment, and justifies why the correction is needed.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eb97fd3 and ff77150.

📒 Files selected for processing (1)

• contracts/mocks/proxy/ClashingImplementation.sol (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)

• GitHub Check: slither
• GitHub Check: tests-foundry
• GitHub Check: tests
• GitHub Check: tests-upgradeable
• GitHub Check: coverage
• GitHub Check: halmos
• GitHub Check: Redirect rules - solidity-contracts
• GitHub Check: Header rules - solidity-contracts
• GitHub Check: Pages changed - solidity-contracts

🔇 Additional comments (1)

contracts/mocks/proxy/ClashingImplementation.sol (1)

6-7: LGTM! Documentation now correctly references the clashing function.

The updated comment accurately reflects the contract's purpose and correctly references upgradeToAndCall(address,bytes), which matches the actual function implementation at line 12 and is indeed part of TransparentUpgradeableProxy's external interface.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}