Skip to content

[Feature] Heritable contract #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 20 commits into from
Closed

[Feature] Heritable contract #595

wants to merge 20 commits into from

Conversation

azavalla
Copy link
Contributor

@azavalla azavalla commented Dec 2, 2017

No description provided.

@azavalla
Inheritable contract
afb2c0f
@azavalla
name fix
dfc58f4
@azavalla
fixes
12f9b12
@azavalla
added example use-case for Inheritable.sol
947e8f9
@azavalla
Use Inherited event instead of OwnershipTransfered
c5d63f8
@azavalla
changed 'pronounce' for 'proclaim'
d15c02e
@azavalla
marked ownerLives as view
fc4d436
@azavalla
further example documentation
dcdde0c
@azavalla
changed events names on inheritable test
38135c5
@azavalla
changed view for constant
4f563df
@azavalla
setHeartbeatTimeout: public --> internal
fc4b95a
@azavalla
owner can't be set as heir
a31ba00
@azavalla
changed Inherited event for OwnershipTransfered
8949b3e
@azavalla
added test for SimpleSavingsWallet
52f8f67
@azavalla
[Inheritable.js] replace assertJump for expectThrow
367cf25
@azavalla
[SimpleSavingsWallet.js] replace assertJump for expectThrow
a63fef7
@azavalla
renamed Inheritable --> Heritable
6853b3d
@azavalla
[Heritable] ownerLives(): constant --> view
02e45c7
@azavalla
[Heritable] added HeirOwnershipClaimed event
4bbeae5
@eternauta1337 eternauta1337 added review feature New contracts, functions, or helpers. and removed review labels Jan 2, 2018
AugustoL
AugustoL reviewed Jan 5, 2018
View reviewed changes
Copy link
Contributor

@AugustoL AugustoL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better if the Heritable contract is tested with a mock contract, we have a mocks folder for that, but dont remove the SimpleSavingsWallet, it is a useful example!

@eternauta1337 eternauta1337 self-assigned this Jan 16, 2018
@eternauta1337 eternauta1337 added review and removed next labels Jan 16, 2018
@eternauta1337 eternauta1337 mentioned this pull request Jan 16, 2018
Merged
@eternauta1337
Copy link
Contributor

Closing and merging manually via PR #680

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@AugustoL AugustoL AugustoL left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@eternauta1337 eternauta1337

Labels
feature New contracts, functions, or helpers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@azavalla @eternauta1337 @AugustoL