Skip to content

Remove unused setBaseURI tests #5456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 24, 2025
Merged

Remove unused setBaseURI tests #5456

merged 2 commits into from
Jan 24, 2025

Conversation

RenanSouza2
Copy link
Contributor

  • Tests
  • Documentation

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 24, 2025

⚠️ No Changeset found

Latest commit: 0e32474

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Amxx
Copy link
Collaborator

Amxx commented Jan 24, 2025

Note: neither the core ERC721 contract nor any of its extensions include a setBaseURI function. It is only available in contracts/mocks/token/ERC721URIStorageMock.sol to test the impact of _baseURI() on the derived URI of tokens.

This is tested in test/token/ERC721/extensions/ERC721URIStorage.test.js directly (without using the behavior).

Therefore, the behavior is always executed on mocks that do NOT include a mechanism to update the _baseURI after construction. This means the section of tests deleted in this PR is in fact never executed (always skipped)

@Amxx Amxx requested review from arr00 and ernestognw January 24, 2025 16:39
ernestognw
ernestognw approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RenanSouza2

@ernestognw ernestognw changed the title remove unused tests Remove unused setBaseURI tests Jan 24, 2025
@ernestognw ernestognw merged commit 6e752dc into OpenZeppelin:master Jan 24, 2025
17 checks passed
@Amxx
Copy link
Collaborator

Amxx commented Jan 24, 2025

Capture d’écran du 2025-01-24 17-47-48

@RenanSouza2 RenanSouza2 deleted the erc721-tests branch January 24, 2025 16:56
Dargon789 added a commit to Dargon789/openzeppelin-contracts that referenced this pull request Feb 15, 2025
@Dargon789 @ernestognw
@heueristik @github-actions @Amxx @0xsambugs @arr00 @famouswizard @leopardracer @cairoeth @frangio @0xsimka @voronor @ericglau @rnkrtt @pcaversaccio @renovate @RenanSouza2 @futreall @Marcofann @mdqst @Dimitrolito @donatik27 @Danyylka @Daulox92 @0xbryer @NeoByteXx @sky-coderay @brawncode @vtjl10 @zeevick10 @annwag @Hopium21 @YanVictorSN @ursulabauer @0xmichalis @xdaluca @JSeiferth @dangerousfood
Test CI/CD OpenZeppelin (#7)
9d08a58 
* Update ReentrancyGuardTransient documentation (OpenZeppelin#5417)

* Optimize `MerkleTree` for loops by using `uint256` iterators (OpenZeppelin#5415)

Co-authored-by: Ernesto García <[email protected]>

* Update `_revokeRole` documentation in AccessControl (OpenZeppelin#5321)

Co-authored-by: Ernesto García <[email protected]>

* Merge release-v5.2 branch (OpenZeppelin#5424)

Signed-off-by: Hadrien Croubois <[email protected]>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Hadrien Croubois <[email protected]>
Co-authored-by: Sam Bugs <[email protected]>
Co-authored-by: Ernesto García <[email protected]>
Co-authored-by: Arr00 <[email protected]>
Co-authored-by: wizard <[email protected]>
Co-authored-by: leopardracer <[email protected]>
Co-authored-by: cairo <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Francisco Giordano <[email protected]>
Co-authored-by: Simka <[email protected]>
Co-authored-by: Voronor <[email protected]>

* Add a Calldata library with `emptyBytes` and `emptyString` functions (OpenZeppelin#5422)

Co-authored-by: Ernesto García <[email protected]>

* Update governor docs (OpenZeppelin#5420)

* Add missing `Calldata`, `Bytes`, `CAIP2` and `CAIP10` API references (OpenZeppelin#5428)

* Expose `_isTrustedByTarget` internally in ERC2771Forwarder (OpenZeppelin#5416)

* Update LICENSE (OpenZeppelin#5434)

* Refactor EnumerableSet.behavior.js for reuse in the community repo (OpenZeppelin#5441)

* Replace `overriden` with `overridden` in GovernorCountingOverridable.sol (OpenZeppelin#5446)

Co-authored-by: Arr00 <[email protected]>
Co-authored-by: ernestognw <[email protected]>

* Remove Unnecessary Initialisation of `_paused` (OpenZeppelin#5448)

Co-authored-by: Ernesto García <[email protected]>

* Fix Broken Docs References (OpenZeppelin#5436)

* Update actions/upload-artifact action to v4 (OpenZeppelin#4826)

* Remove unused `setBaseURI` tests (OpenZeppelin#5456)

Co-authored-by: Hadrien Croubois <[email protected]>

* Group typographical errors (OpenZeppelin#5443)

Co-authored-by: futreall <[email protected]>
Co-authored-by: Marco <[email protected]>
Co-authored-by: Dmitry <[email protected]>
Co-authored-by: Dmytrol <[email protected]>
Co-authored-by: Noisy <[email protected]>
Co-authored-by: Danil <[email protected]>
Co-authored-by: CrazyFrog <[email protected]>
Co-authored-by: Bryer <[email protected]>
Co-authored-by: Viktor Pavlik <[email protected]>
Co-authored-by: Skylar Ray <[email protected]>
Co-authored-by: Brawn <[email protected]>
Co-authored-by: fuder.eth <[email protected]>
Co-authored-by: FT <[email protected]>
Co-authored-by: Ann Wagner <[email protected]>
Co-authored-by: Hopium <[email protected]>
Co-authored-by: Arr00 <[email protected]>
Co-authored-by: Hadrien Croubois <[email protected]>

* Fix interface docs ordering and add missing interface (OpenZeppelin#5460)

* Add a governor extension that implements a proposal guardian (OpenZeppelin#5303)

Co-authored-by: Arr00 <[email protected]>
Co-authored-by: Ernesto García <[email protected]>

* Fix the CLI output of formal verification runs (OpenZeppelin#5445)

* Update dependency halmos to v0.2.4 (OpenZeppelin#5461)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Use stable foundry version in CI (OpenZeppelin#5465)

* Add stake management function to ERC4337Utils (OpenZeppelin#5471)

* Add forum badge correct link (OpenZeppelin#5481)

* SafeERC20.trySafeTransfer{,from} (OpenZeppelin#5483)

* Improve promise rejections handling in hardhat/async-test-sanity.js (OpenZeppelin#5429)

Co-authored-by: Arr00 <[email protected]>

* Use slither v0.10.4 (OpenZeppelin#5488)

* Add ERC6909 Implementation along with extensions (OpenZeppelin#5394)

Co-authored-by: Hadrien Croubois <[email protected]>
Co-authored-by: Ernesto García <[email protected]>

* Rename ERC4337Utils ENTRYPOINT to ENTRYPOINT_V07 (OpenZeppelin#5472)

Co-authored-by: Hadrien Croubois <[email protected]>

* Add Bytes32x2Set (OpenZeppelin#5442)

Co-authored-by: Ernesto García <[email protected]>

* Add clear function to Enumerable{Set,Map} (OpenZeppelin#5486)

Co-authored-by: Hadrien Croubois <[email protected]>

* Make set-max-old-space-size.sh compatible with sh (OpenZeppelin#5493)

Co-authored-by: Hadrien Croubois <[email protected]>

* Update FUNDING.json (OpenZeppelin#5496)

Co-authored-by: Hadrien Croubois <[email protected]>

* Update FUNDING.json hierarchy (OpenZeppelin#5500)

Co-authored-by: Hadrien Croubois <[email protected]>

* Test behavior of SignatureChecker against the identity precompile (0x4) (OpenZeppelin#5501)

* Treat code-size warnings as errors (OpenZeppelin#5101)

Co-authored-by: Hadrien Croubois <[email protected]>

* Make `TimelockController` receive function virtual (OpenZeppelin#5506)

Co-authored-by: Arr00 <[email protected]>
Co-authored-by: Hadrien Croubois <[email protected]>

---------

Signed-off-by: Hadrien Croubois <[email protected]>
Co-authored-by: Ernesto García <[email protected]>
Co-authored-by: Michael <[email protected]>
Co-authored-by: Maks <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Hadrien Croubois <[email protected]>
Co-authored-by: Sam Bugs <[email protected]>
Co-authored-by: Arr00 <[email protected]>
Co-authored-by: wizard <[email protected]>
Co-authored-by: leopardracer <[email protected]>
Co-authored-by: cairo <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Francisco Giordano <[email protected]>
Co-authored-by: Simka <[email protected]>
Co-authored-by: Voronor <[email protected]>
Co-authored-by: Eric Lau <[email protected]>
Co-authored-by: planetBoy <[email protected]>
Co-authored-by: sudo rm -rf --no-preserve-root / <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Renan Souza <[email protected]>
Co-authored-by: futreall <[email protected]>
Co-authored-by: Marco <[email protected]>
Co-authored-by: Dmitry <[email protected]>
Co-authored-by: Dmytrol <[email protected]>
Co-authored-by: Noisy <[email protected]>
Co-authored-by: Danil <[email protected]>
Co-authored-by: CrazyFrog <[email protected]>
Co-authored-by: Bryer <[email protected]>
Co-authored-by: Viktor Pavlik <[email protected]>
Co-authored-by: Skylar Ray <[email protected]>
Co-authored-by: Brawn <[email protected]>
Co-authored-by: fuder.eth <[email protected]>
Co-authored-by: FT <[email protected]>
Co-authored-by: Ann Wagner <[email protected]>
Co-authored-by: Hopium <[email protected]>
Co-authored-by: Yan Victor SN <[email protected]>
Co-authored-by: Ursula <[email protected]>
Co-authored-by: Michalis Kargakis <[email protected]>
Co-authored-by: luca <[email protected]>
Co-authored-by: Jonas <[email protected]>
Co-authored-by: Joseph Delong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amxx Amxx Amxx approved these changes

@ernestognw ernestognw ernestognw approved these changes

@arr00 arr00 Awaiting requested review from arr00

Assignees
No one assigned
Labels
ignore-changeset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RenanSouza2 @Amxx @ernestognw