Skip to content

Conversation

0xminds
Copy link

@0xminds 0xminds commented Jan 13, 2025

I noticed that in the writeEntry function, the symbols for displaying the result of a check are used incorrectly. Currently, :x: (cross) is shown for success, and :heavy_check_mark: (checkmark) is shown for errors.

This is counterintuitive, as a cross typically represents an error, and a checkmark represents success.

I’ve swapped these symbols to align with common conventions and improve clarity.

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

Fix incorrect symbols for success/error in writeEntry function
Copy link

changeset-bot bot commented Jan 13, 2025

⚠️ No Changeset found

Latest commit: 05b9e11

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Amxx
Copy link
Collaborator

Amxx commented Feb 3, 2025

Already fixed in #5445

@Amxx Amxx closed this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants