Skip to content

Expose _isTrustedByTarget internally in ERC2771Forwarder #5416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Expose _isTrustedByTarget internally in ERC2771Forwarder #5416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcb02ff
Expose internally in ERC2771Forwarder
ernestognw Jan 6, 2025
93bc05a
Update contracts/metatx/ERC2771Forwarder.sol
ernestognw Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/famous-timers-compare.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'openzeppelin-solidity': minor
---

`ERC2771Forwarder`: Expose the `_isTrustedByTarget` internal function to check whether a target trusts the forwarder.
5 changes: 4 additions & 1 deletion contracts/metatx/ERC2771Forwarder.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,8 +302,11 @@ contract ERC2771Forwarder is EIP712, Nonces {
*
* This function performs a static call to the target contract calling the
* {ERC2771Context-isTrustedForwarder} function.
*
* NOTE: Consider the execution of this forwarder is permissionless. Without this check, anyone may transfer assets
* that are owned by, or are approved to this forwarder.
*/
function _isTrustedByTarget(address target) private view returns (bool) {
function _isTrustedByTarget(address target) internal view virtual returns (bool) {
bytes memory encodedParams = abi.encodeCall(ERC2771Context.isTrustedForwarder, (address(this)));

bool success;
Expand Down
Loading