Skip to content

Use address(this) instead of this #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 31, 2018
Merged

Use address(this) instead of this #1134

merged 3 commits into from
Jul 31, 2018

Conversation

rstormsf
Copy link
Contributor

🚀 Description

It's preferred to use address(this) vs this

  • 📘 I've reviewed the OpenZeppelin Contributor Guidelines
  • [] ✅ I've added tests where applicable to test my new functionality.
  • 📖 I've made sure that my contracts are well-documented.
  • 🎨 I've run the JS/Solidity linters and fixed any issues (npm run lint:all:fix).

rstormsf added 2 commits July 30, 2018 21:43
@rstormsf
Use address(this) instead of this
273867e 
It's preferred to use `address(this)` vs `this`
@rstormsf
Change to address(this) vs this
804f3ce
come-maiz
come-maiz previously approved these changes Jul 31, 2018
View reviewed changes
Copy link

@come-maiz come-maiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Thank you @rstormsf

@nventuro nventuro merged commit 56735a7 into OpenZeppelin:master Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@nventuro nventuro nventuro approved these changes

@come-maiz come-maiz come-maiz left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rstormsf @come-maiz @nventuro