Skip to content

Made remaining public fallback functions external #1080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2018
Merged

Made remaining public fallback functions external #1080

merged 1 commit into from
Jul 20, 2018

Conversation

dougiebuckets
Copy link
Contributor

Fixes #1075

🚀 Description

Made remaining public fallback functions external per #1075

  • 📘 I've reviewed the OpenZeppelin Contributor Guidelines
  • ✅ I've run all tests; everything looks good
  • 🎨 I've run the JS/Solidity linters and fixed any issues (npm run lint:all:fix).

nventuro
nventuro approved these changes Jul 20, 2018
View reviewed changes
Copy link
Contributor

@nventuro nventuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay compilation now passes! The ECRecovery test errored out though, I'll look into that.

@nventuro
Copy link
Contributor

Thanks @dougiebuckets!

@nventuro nventuro merged commit ce0c327 into OpenZeppelin:master Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@nventuro nventuro nventuro approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make fallback functions external for Solidity 0.5.0
2 participants
@dougiebuckets @nventuro